merged [12852] Color player counts in the multiplayer public lobby list #12852

Closed
opened 2026-01-02 20:41:45 -03:00 by Accord · 0 comments
Owner

Branch: __refs_pull_12852_head

Calinou opened issue at 2024-01-30 01:12:

  • Full lobbies have their player count displayed in red.
  • Lobbies with one slot left have their player count displayed in orange.
  • Empty lobbies have their player count grayed out.
    This makes the lobby list easier to visually parse.

Preview

Light theme

Screenshot_20240130_010523 | Screenshot_20240130_010713

-|-

Dark theme

Screenshot_20240130_010333 |

-|

FearlessTobi commented at 2024-01-30 12:28:

Please fix clang-format.

FearlessTobi commented at 2024-02-05 15:54:

I know this is pretty late, but I find the text very hard to read for rooms with a player count of >0 and <max_size-1.
In dark themes it is almost unreadable.

Calinou commented at 2024-02-05 16:05:

I know this is pretty late, but I find the text very hard to read for rooms with a player count of >0 and <max_size-1. In dark themes it is almost unreadable.
This is what I pointed out with https://github.com/yuzu-emu/yuzu/pull/12852#discussion_r1470451979, but I guess it wasn't obvious that it broke dark theme support (something I noticed on my end while testing). Sorry 🙁
I suppose a workaround is to use a green color that's readable on both dark and light backgrounds for those player counts (perhaps 32, 160, 32), but I'd prefer just using the "default color" as if it wasn't overridden.

german77 commented at 2024-02-05 16:36:

@Calinou See this code https://github.com/yuzu-emu/yuzu/blob/master/src/yuzu/configuration/configure_input_player_widget.cpp#L63
It handles different color palettes depending on theme

[Export of Github issue for yuzu-emu/yuzu. Generated on 2024.02.28 at 10:04:32.]

**Branch:** [__refs_pull_12852_head](https://accord.dravee.dev/Accord/yuzu-mirror/src/branch/__refs_pull_12852_head) #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/180032?v=4" width="50"></div>[Calinou](https://github.com/Calinou) opened issue at [2024-01-30 01:12](https://github.com/yuzu-emu/yuzu/pull/12852): > - Full lobbies have their player count displayed in red. > - Lobbies with one slot left have their player count displayed in orange. > - Empty lobbies have their player count grayed out. > This makes the lobby list easier to visually parse. > ## Preview > ### Light theme ![Screenshot_20240130_010523](https://github.com/yuzu-emu/yuzu/assets/180032/1ef290d1-041c-412c-bb57-9e405a1fc282) | ![Screenshot_20240130_010713](https://github.com/yuzu-emu/yuzu/assets/180032/b648eb2a-1e39-4453-8c87-0d00ef63a893) > -|- > ### Dark theme ![Screenshot_20240130_010333](https://github.com/yuzu-emu/yuzu/assets/180032/1f3109f0-f146-4486-a874-3bd8123ecbc8) | > -| #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/20753089?u=4c1e2e5b0b4b5b40b1004b7fe0948d56f0adaf50&v=4" width="50"></div>[FearlessTobi](https://github.com/FearlessTobi) commented at [2024-01-30 12:28](https://github.com/yuzu-emu/yuzu/pull/12852#issuecomment-1916739520): > Please fix clang-format. #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/20753089?u=4c1e2e5b0b4b5b40b1004b7fe0948d56f0adaf50&v=4" width="50"></div>[FearlessTobi](https://github.com/FearlessTobi) commented at [2024-02-05 15:54](https://github.com/yuzu-emu/yuzu/pull/12852#issuecomment-1927314201): > I know this is pretty late, but I find the text very hard to read for rooms with a player count of `>0 and <max_size-1`. > In dark themes it is almost unreadable. #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/180032?v=4" width="50"></div>[Calinou](https://github.com/Calinou) commented at [2024-02-05 16:05](https://github.com/yuzu-emu/yuzu/pull/12852#issuecomment-1927335918): > > I know this is pretty late, but I find the text very hard to read for rooms with a player count of `>0 and <max_size-1`. In dark themes it is almost unreadable. > This is what I pointed out with https://github.com/yuzu-emu/yuzu/pull/12852#discussion_r1470451979, but I guess it wasn't obvious that it broke dark theme support (something I noticed on my end while testing). Sorry :slightly_frowning_face: > I suppose a workaround is to use a green color that's readable on both dark and light backgrounds for those player counts (perhaps `32, 160, 32`), but I'd prefer just using the "default color" as if it wasn't overridden. #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/5944268?u=0ce9c0fd0fb51813509fedff9ee9fa0ec1ff42dc&v=4" width="50"></div>[german77](https://github.com/german77) commented at [2024-02-05 16:36](https://github.com/yuzu-emu/yuzu/pull/12852#issuecomment-1927409015): > @Calinou See this code https://github.com/yuzu-emu/yuzu/blob/master/src/yuzu/configuration/configure_input_player_widget.cpp#L63 > It handles different color palettes depending on theme > ------------------------------------------------------------------------------- > [Export of Github issue for [yuzu-emu/yuzu](https://github.com/yuzu-emu/yuzu). Generated on 2024.02.28 at 10:04:32.]
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Accord/yuzu-mirror#12852
No description provided.