merged [12930] Fix multiplayer player count color in dark themes | Temp fix until #12744: Add green color for counts > 0 and < max_players - 1 #12930

Closed
opened 2026-01-02 20:42:11 -03:00 by Accord · 0 comments
Owner

Branch: __refs_pull_12930_head

Kevnkkm opened issue at 2024-02-06 02:28:

This fixes #12852 to the intended color in dark and midnight themes.

Preview

Before | After :-------------------------:|:-------------------------:

image | image

Calinou commented at 2024-02-06 02:47:

Tested locally, the dark theme detection logic doesn't detect my system-wide dark theme on Linux (KDE Breeze Dark on Fedora 39), so it doesn't work:

image

This is why I'd prefer using the non-overridden color, so that the dark/light text color is picked appropriately by the OS without relying on theme detection. This is also because the default text color on this dark theme isn't exactly pure white – it's slightly darker (something like 240, 240, 240).
I'm pretty sure I've seen this behavior in at least one Qt app out there (perhaps qBittorrent's list of torrents view), we just need to find how it's done 🙂

Kevnkkm commented at 2024-02-06 03:18:

Ahh, I see! Sorry it was a bit unclear. 😅 As you suggested yourself, should a (green) color be used in the meantime until the correct behavior is figured out?
Suggested color 32, 160, 32 would look like this (quite nice imo):

White Dark Midnight

grafik | grafik | grafik

flodavid commented at 2024-02-06 09:29:

I am currently reworking dark theme detection, see https://github.com/yuzu-emu/yuzu/pull/12744

Kevnkkm commented at 2024-02-06 16:53:

a50f659 until #12744 is done

[Export of Github issue for yuzu-emu/yuzu. Generated on 2024.02.28 at 10:04:32.]

**Branch:** [__refs_pull_12930_head](https://accord.dravee.dev/Accord/yuzu-mirror/src/branch/__refs_pull_12930_head) #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/56404895?u=684a7aa021f82a1e2c577643189695f51460b1b5&v=4" width="50"></div>[Kevnkkm](https://github.com/Kevnkkm) opened issue at [2024-02-06 02:28](https://github.com/yuzu-emu/yuzu/pull/12930): > This fixes #12852 to the intended color in dark and midnight themes. > <h2>Preview</h2> > Before | After > :-------------------------:|:-------------------------: ![image](https://github.com/yuzu-emu/yuzu/assets/56404895/98f87aac-deca-4589-9afa-917fabc00458) | ![image](https://github.com/yuzu-emu/yuzu/assets/56404895/6f733e23-05ee-4f08-9724-7e1efdd63f06) #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/180032?v=4" width="50"></div>[Calinou](https://github.com/Calinou) commented at [2024-02-06 02:47](https://github.com/yuzu-emu/yuzu/pull/12930#issuecomment-1928684507): > Tested locally, the dark theme detection logic doesn't detect my system-wide dark theme on Linux (KDE Breeze Dark on Fedora 39), so it doesn't work: ![image](https://github.com/yuzu-emu/yuzu/assets/180032/b288dbab-cfea-45fc-a202-85a98f496365) > This is why I'd prefer using the non-overridden color, so that the dark/light text color is picked appropriately by the OS without relying on theme detection. This is also because the default text color on this dark theme isn't exactly pure white – it's slightly darker (something like `240, 240, 240`). > I'm pretty sure I've seen this behavior in at least one Qt app out there (perhaps qBittorrent's list of torrents view), we just need to find how it's done :slightly_smiling_face: #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/56404895?u=684a7aa021f82a1e2c577643189695f51460b1b5&v=4" width="50"></div>[Kevnkkm](https://github.com/Kevnkkm) commented at [2024-02-06 03:18](https://github.com/yuzu-emu/yuzu/pull/12930#issuecomment-1928711692): > Ahh, I see! Sorry it was a bit unclear. 😅 As you suggested yourself, should a (green) color be used in the meantime until the correct behavior is figured out? > Suggested color `32, 160, 32` would look like this (quite nice imo): > | White | Dark | Midnight | > |-------|-------|----------| ![grafik](https://github.com/yuzu-emu/yuzu/assets/56404895/33a82cfc-e531-4c20-bec8-f7849dd2670a) | ![grafik](https://github.com/yuzu-emu/yuzu/assets/56404895/536bf93e-72d5-4be8-a523-d0b0cabda218) | ![grafik](https://github.com/yuzu-emu/yuzu/assets/56404895/347a339d-ec3d-431a-9e83-5c7bb607ded7) #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/11854849?u=7d079e6737153cbd7b70e4feacc41cba312cf666&v=4" width="50"></div>[flodavid](https://github.com/flodavid) commented at [2024-02-06 09:29](https://github.com/yuzu-emu/yuzu/pull/12930#issuecomment-1929109526): > I am currently reworking dark theme detection, see https://github.com/yuzu-emu/yuzu/pull/12744 #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/56404895?u=684a7aa021f82a1e2c577643189695f51460b1b5&v=4" width="50"></div>[Kevnkkm](https://github.com/Kevnkkm) commented at [2024-02-06 16:53](https://github.com/yuzu-emu/yuzu/pull/12930#issuecomment-1930353130): > [a50f659](https://github.com/yuzu-emu/yuzu/pull/12930/commits/a50f6597c255cbf2306345807b533999eb807165) until #12744 is done > ------------------------------------------------------------------------------- > [Export of Github issue for [yuzu-emu/yuzu](https://github.com/yuzu-emu/yuzu). Generated on 2024.02.28 at 10:04:32.]
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Accord/yuzu-mirror#12930
No description provided.