Accord/yuzu-mirror
1
0
Fork 0
Code Issues 1.6k Pull requests 44 Projects Releases Packages Wiki Activity Actions

open [11623] emit_spirv: implement descriptor indexing #11623

Open
Accord wants to merge 1 commit from __refs_pull_11623_head into master
pull from: __refs_pull_11623_head
merge into: Accord:master
Conversation 0 Commits 1 Files changed 4 +49 -28
Accord commented 2026-01-02 20:35:01 -03:00
Owner
Copy link

Branch: __refs_pull_11623_head

Labels: gpu-new, vulkan

liamwhite opened issue at 2023-09-27 23:12:

Works okay with my limited homebrew tests, need to find some games that use these

liamwhite commented at 2023-10-08 01:08:

Closing until we get a retail program that needs this

liamwhite commented at 2023-10-08 21:27:

Found one: #11700

Squall-Leonhart commented at 2023-10-12 10:02:

https://github.com/yuzu-emu/yuzu/issues/11754 Maybe another

apricotbucket28 commented at 2023-11-12 16:07:

This fixes a lot of rendering issues in LM3.
Switch:

2023102515585000_c

Mainline/master:

0100dca0064a6000_2023-10-23_17-13-11-215

This PR:

0100dca0064a6000_2023-11-12_12-56-24-230

Squall-Leonhart commented at 2023-11-20 04:44:

The recent change to the Opus reference has made it a pain to switch to this branch, can it get a rebase?

Squall-Leonhart commented at 2023-11-20 04:53:

Nvm, i had to clear my local cache and get it again

oscarbg commented at 2023-12-01 14:55:

This fixes a lot of rendering issues in LM3.

Switch: 2023102515585000_c

Mainline/master: 0100dca0064a6000_2023-10-23_17-13-11-215

This PR: 0100dca0064a6000_2023-11-12_12-56-24-230
Curious what fix beyond in this PR is needed for the mirror reflection to work? Even with this PR, mirror is black..

[Export of Github issue for yuzu-emu/yuzu. Generated on 2024.02.28 at 10:04:32.]

**Branch:** [__refs_pull_11623_head](https://accord.dravee.dev/Accord/yuzu-mirror/src/branch/__refs_pull_11623_head) > **Labels**: `gpu-new`, `vulkan` #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/9658600?v=4" width="50"></div>[liamwhite](https://github.com/liamwhite) opened issue at [2023-09-27 23:12](https://github.com/yuzu-emu/yuzu/pull/11623): > Works okay with my limited homebrew tests, need to find some games that use these #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/9658600?v=4" width="50"></div>[liamwhite](https://github.com/liamwhite) commented at [2023-10-08 01:08](https://github.com/yuzu-emu/yuzu/pull/11623#issuecomment-1751881967): > Closing until we get a retail program that needs this #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/9658600?v=4" width="50"></div>[liamwhite](https://github.com/liamwhite) commented at [2023-10-08 21:27](https://github.com/yuzu-emu/yuzu/pull/11623#issuecomment-1752166392): > Found one: #11700 #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/1098176?v=4" width="50"></div>[Squall-Leonhart](https://github.com/Squall-Leonhart) commented at [2023-10-12 10:02](https://github.com/yuzu-emu/yuzu/pull/11623#issuecomment-1759310139): > https://github.com/yuzu-emu/yuzu/issues/11754 Maybe another #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/71973804?u=0c2c15d7544c42b1b248818a956335d3af7e6b3c&v=4" width="50"></div>[apricotbucket28](https://github.com/apricotbucket28) commented at [2023-11-12 16:07](https://github.com/yuzu-emu/yuzu/pull/11623#issuecomment-1807170067): > This fixes a lot of rendering issues in LM3. > Switch: ![2023102515585000_c](https://github.com/yuzu-emu/yuzu/assets/71973804/f24c155b-c809-4741-ade0-40eb23958696) > Mainline/master: ![0100dca0064a6000_2023-10-23_17-13-11-215](https://github.com/yuzu-emu/yuzu/assets/71973804/3fbdac25-c070-418f-8fd5-3d531db31899) > This PR: ![0100dca0064a6000_2023-11-12_12-56-24-230](https://github.com/yuzu-emu/yuzu/assets/71973804/f98e074c-c112-4fce-85a8-c42ea759c179) #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/1098176?v=4" width="50"></div>[Squall-Leonhart](https://github.com/Squall-Leonhart) commented at [2023-11-20 04:44](https://github.com/yuzu-emu/yuzu/pull/11623#issuecomment-1818221003): > The recent change to the Opus reference has made it a pain to switch to this branch, can it get a rebase? #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/1098176?v=4" width="50"></div>[Squall-Leonhart](https://github.com/Squall-Leonhart) commented at [2023-11-20 04:53](https://github.com/yuzu-emu/yuzu/pull/11623#issuecomment-1818226572): > Nvm, i had to clear my local cache and get it again #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/669305?v=4" width="50"></div>[oscarbg](https://github.com/oscarbg) commented at [2023-12-01 14:55](https://github.com/yuzu-emu/yuzu/pull/11623#issuecomment-1836258475): > > This fixes a lot of rendering issues in LM3. > > > > Switch: ![2023102515585000_c](https://private-user-images.githubusercontent.com/71973804/282310636-f24c155b-c809-4741-ade0-40eb23958696.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDE0NDI3MDksIm5iZiI6MTcwMTQ0MjQwOSwicGF0aCI6Ii83MTk3MzgwNC8yODIzMTA2MzYtZjI0YzE1NWItYzgwOS00NzQxLWFkZTAtNDBlYjIzOTU4Njk2LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzEyMDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMjAxVDE0NTMyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIwY2ViYzMwNjhmOTE3NzQ1NjM3YmJkMGQ4MGZmYmZhMTQ1OWFmZTk5ZTZkYzU4NGQ2YjY2MjJiNThlMmM0NzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1S_bEaiIkiSGU42lkkmfLjDKwlsm8tTmd3M4uHlunDc) > > > > Mainline/master: ![0100dca0064a6000_2023-10-23_17-13-11-215](https://private-user-images.githubusercontent.com/71973804/282310664-3fbdac25-c070-418f-8fd5-3d531db31899.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDE0NDI3MDksIm5iZiI6MTcwMTQ0MjQwOSwicGF0aCI6Ii83MTk3MzgwNC8yODIzMTA2NjQtM2ZiZGFjMjUtYzA3MC00MThmLThmZDUtM2Q1MzFkYjMxODk5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzEyMDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMjAxVDE0NTMyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE0YjNjZjhiMzViNTQ0ZDUwZGRhMWI3ZTU2MGJiNDAxMzU0MzllYTA1ODRjYTVlMmE2NjhkNjJlMmFiNDJhNTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.GUpm_1uDHxQlhBnXWSFom4gnpOXwLPPJcTMvJD6TTGA) > > > > This PR: ![0100dca0064a6000_2023-11-12_12-56-24-230](https://private-user-images.githubusercontent.com/71973804/282310756-f98e074c-c112-4fce-85a8-c42ea759c179.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDE0NDI3MDksIm5iZiI6MTcwMTQ0MjQwOSwicGF0aCI6Ii83MTk3MzgwNC8yODIzMTA3NTYtZjk4ZTA3NGMtYzExMi00ZmNlLTg1YTgtYzQyZWE3NTljMTc5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzEyMDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMjAxVDE0NTMyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc2OTNjZjhmYjA0MzNhMmYwYTI5MTAwMTcxNTYwZDEyNzAzYWJhOTUwMzMzYmYxNGUxZmJkYjk2M2MzN2Y5YzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QzFEBT55iu2XplqVp4Ci0sXRx3ONujIoqMgagyETssY) > Curious what fix beyond in this PR is needed for the mirror reflection to work? Even with this PR, mirror is black.. > ------------------------------------------------------------------------------- > [Export of Github issue for [yuzu-emu/yuzu](https://github.com/yuzu-emu/yuzu). Generated on 2024.02.28 at 10:04:32.]
emit_spirv: implement descriptor indexing
Some checks failed
yuzu-ci / reuse (pull_request) Has been cancelled
Details
codespell / Check for spelling errors (pull_request) Has been cancelled
Details
yuzu-ci / transifex (pull_request) Has been cancelled
Details
yuzu verify / verify format (pull_request) Has been cancelled
Details
yuzu verify / test build (pull_request) Has been cancelled
Details
yuzu verify / test build-1 (pull_request) Has been cancelled
Details
yuzu verify / test build-2 (pull_request) Has been cancelled
Details
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
Details
yuzu verify / android (pull_request) Has been cancelled
Details
bec2aa0740
Some checks failed
yuzu-ci / reuse (pull_request) Has been cancelled
Details
codespell / Check for spelling errors (pull_request) Has been cancelled
Details
yuzu-ci / transifex (pull_request) Has been cancelled
Details
yuzu verify / verify format (pull_request) Has been cancelled
Details
yuzu verify / test build (pull_request) Has been cancelled
Details
yuzu verify / test build-1 (pull_request) Has been cancelled
Details
yuzu verify / test build-2 (pull_request) Has been cancelled
Details
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
Details
yuzu verify / android (pull_request) Has been cancelled
Details
This pull request has changes conflicting with the target branch.
  • src/shader_recompiler/backend/spirv/emit_spirv_image.cpp
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin __refs_pull_11623_head:__refs_pull_11623_head
git switch __refs_pull_11623_head

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff __refs_pull_11623_head
git switch __refs_pull_11623_head
git rebase master
git switch master
git merge --ff-only __refs_pull_11623_head
git switch __refs_pull_11623_head
git rebase master
git switch master
git merge --no-ff __refs_pull_11623_head
git switch master
git merge --squash __refs_pull_11623_head
git switch master
git merge --ff-only __refs_pull_11623_head
git switch master
git merge __refs_pull_11623_head
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Accord/yuzu-mirror!11623
No description provided.