open [12195] Shaders: Stub Cbuf accesses for UBO bindings exceeding host device limits #12195

Open
Accord wants to merge 3 commits from __refs_pull_12195_head into master
Owner

Branch: __refs_pull_12195_head

ameerj opened issue at 2023-11-27 04:24:

This should resolve shader compilation failures on devices with low UBO limits

Squall-Leonhart commented at 2023-11-28 01:24:

what should I test this change against game wise?

liamwhite commented at 2023-12-04 14:17:

Reported to regress rendering in Super Mario Bros Wonder on Pascal

image


[Export of Github issue for yuzu-emu/yuzu. Generated on 2024.02.28 at 10:04:32.]

**Branch:** [__refs_pull_12195_head](https://accord.dravee.dev/Accord/yuzu-mirror/src/branch/__refs_pull_12195_head) #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/52414509?u=cf8872d7a177597b3d4611fb1ab9486a4fa8ec89&v=4" width="50"></div>[ameerj](https://github.com/ameerj) opened issue at [2023-11-27 04:24](https://github.com/yuzu-emu/yuzu/pull/12195): > This should resolve shader compilation failures on devices with low UBO limits #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/1098176?v=4" width="50"></div>[Squall-Leonhart](https://github.com/Squall-Leonhart) commented at [2023-11-28 01:24](https://github.com/yuzu-emu/yuzu/pull/12195#issuecomment-1828912800): > what should I test this change against game wise? #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/9658600?v=4" width="50"></div>[liamwhite](https://github.com/liamwhite) commented at [2023-12-04 14:17](https://github.com/yuzu-emu/yuzu/pull/12195#issuecomment-1838730562): > Reported to regress rendering in Super Mario Bros Wonder on Pascal ![image](https://github.com/yuzu-emu/yuzu/assets/9658600/9583bbcc-1da9-4fed-b703-2204f68bb797) > ------------------------------------------------------------------------------- > [Export of Github issue for [yuzu-emu/yuzu](https://github.com/yuzu-emu/yuzu). Generated on 2024.02.28 at 10:04:32.]
runtime_info: initialize all members
Some checks failed
yuzu-ci / transifex (pull_request) Has been cancelled
yuzu-ci / reuse (pull_request) Has been cancelled
codespell / Check for spelling errors (pull_request) Has been cancelled
yuzu verify / verify format (pull_request) Has been cancelled
yuzu verify / test build (pull_request) Has been cancelled
yuzu verify / test build-1 (pull_request) Has been cancelled
yuzu verify / test build-2 (pull_request) Has been cancelled
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
yuzu verify / android (pull_request) Has been cancelled
0fa55fb8bd
Some checks failed
yuzu-ci / transifex (pull_request) Has been cancelled
yuzu-ci / reuse (pull_request) Has been cancelled
codespell / Check for spelling errors (pull_request) Has been cancelled
yuzu verify / verify format (pull_request) Has been cancelled
yuzu verify / test build (pull_request) Has been cancelled
yuzu verify / test build-1 (pull_request) Has been cancelled
yuzu verify / test build-2 (pull_request) Has been cancelled
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
yuzu verify / android (pull_request) Has been cancelled
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin __refs_pull_12195_head:__refs_pull_12195_head
git switch __refs_pull_12195_head

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff __refs_pull_12195_head
git switch __refs_pull_12195_head
git rebase master
git switch master
git merge --ff-only __refs_pull_12195_head
git switch __refs_pull_12195_head
git rebase master
git switch master
git merge --no-ff __refs_pull_12195_head
git switch master
git merge --squash __refs_pull_12195_head
git switch master
git merge --ff-only __refs_pull_12195_head
git switch master
git merge __refs_pull_12195_head
git push origin master
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Accord/yuzu-mirror!12195
No description provided.