Accord/yuzu-mirror
1
0
Fork 0
Code Issues 1.6k Pull requests 44 Projects Releases Packages Wiki Activity Actions

open [13036] service: remove strong dependency on kernel headers #13036

Open
Accord wants to merge 1 commit from __refs_pull_13036_head into master
pull from: __refs_pull_13036_head
merge into: Accord:master
Conversation 0 Commits 1 Files changed 27 +98 -66
Accord commented 2026-01-02 20:42:45 -03:00
Owner
Copy link

Branch: __refs_pull_13036_head

Labels: hle-fix

liamwhite opened issue at 2024-02-17 07:08:

Too many service files still depend on kernel headers directly or indirectly, but this should speed up the build a little bit and make recompiles after changing kernel headers shorter.

FearlessTobi commented at 2024-02-17 16:12:

Looks fine. Does it improve compile times?

liamwhite commented at 2024-02-17 17:27:

It made them worse on CI but it's better locally (I compile without pch for ccache)

[Export of Github issue for yuzu-emu/yuzu. Generated on 2024.02.28 at 10:04:32.]

**Branch:** [__refs_pull_13036_head](https://accord.dravee.dev/Accord/yuzu-mirror/src/branch/__refs_pull_13036_head) > **Labels**: `hle-fix` #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/9658600?v=4" width="50"></div>[liamwhite](https://github.com/liamwhite) opened issue at [2024-02-17 07:08](https://github.com/yuzu-emu/yuzu/pull/13036): > Too many service files still depend on kernel headers directly or indirectly, but this should speed up the build a little bit and make recompiles after changing kernel headers shorter. #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/20753089?u=4c1e2e5b0b4b5b40b1004b7fe0948d56f0adaf50&v=4" width="50"></div>[FearlessTobi](https://github.com/FearlessTobi) commented at [2024-02-17 16:12](https://github.com/yuzu-emu/yuzu/pull/13036#issuecomment-1950246048): > Looks fine. Does it improve compile times? #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/9658600?v=4" width="50"></div>[liamwhite](https://github.com/liamwhite) commented at [2024-02-17 17:27](https://github.com/yuzu-emu/yuzu/pull/13036#issuecomment-1950262840): > It made them worse on CI but it's better locally (I compile without pch for ccache) > ------------------------------------------------------------------------------- > [Export of Github issue for [yuzu-emu/yuzu](https://github.com/yuzu-emu/yuzu). Generated on 2024.02.28 at 10:04:32.]
service: remove strong dependency on kernel headers
Some checks failed
yuzu verify / test build-1 (pull_request) Has been cancelled
Details
yuzu-ci / transifex (pull_request) Has been cancelled
Details
yuzu-ci / reuse (pull_request) Has been cancelled
Details
codespell / Check for spelling errors (pull_request) Has been cancelled
Details
yuzu verify / verify format (pull_request) Has been cancelled
Details
yuzu verify / test build (pull_request) Has been cancelled
Details
yuzu verify / test build-2 (pull_request) Has been cancelled
Details
yuzu verify / test build (macos) (pull_request) Has been cancelled
Details
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
Details
yuzu verify / android (pull_request) Has been cancelled
Details
0151f593ad
Some checks failed
yuzu verify / test build-1 (pull_request) Has been cancelled
Details
yuzu-ci / transifex (pull_request) Has been cancelled
Details
yuzu-ci / reuse (pull_request) Has been cancelled
Details
codespell / Check for spelling errors (pull_request) Has been cancelled
Details
yuzu verify / verify format (pull_request) Has been cancelled
Details
yuzu verify / test build (pull_request) Has been cancelled
Details
yuzu verify / test build-2 (pull_request) Has been cancelled
Details
yuzu verify / test build (macos) (pull_request) Has been cancelled
Details
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
Details
yuzu verify / android (pull_request) Has been cancelled
Details
This pull request has changes conflicting with the target branch.
  • src/core/hle/service/hid/hid_server.cpp
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin __refs_pull_13036_head:__refs_pull_13036_head
git switch __refs_pull_13036_head

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff __refs_pull_13036_head
git switch __refs_pull_13036_head
git rebase master
git switch master
git merge --ff-only __refs_pull_13036_head
git switch __refs_pull_13036_head
git rebase master
git switch master
git merge --no-ff __refs_pull_13036_head
git switch master
git merge --squash __refs_pull_13036_head
git switch master
git merge --ff-only __refs_pull_13036_head
git switch master
git merge __refs_pull_13036_head
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Accord/yuzu-mirror!13036
No description provided.