open [13147] bootmanager: Add wayland protocols #13147

Open
Accord wants to merge 1 commit from __refs_pull_13147_head into master
Owner

Branch: __refs_pull_13147_head

ColinKinloch opened issue at 2024-02-24 01:38:

This fixes mouse panning on wayland.
It also adds wp_viewporter which allows the compositor to scale the framebuffer to the window. This may make resizing the window smoother on slow hardware.

To do

  • Fix viewport on scaled desktops
  • Lock / unlock pointer when mouse panning is disabled / enabled
  • Disable wayland incompatible relative mouse panning on wayland

ColinKinloch commented at 2024-02-24 22:39:

Is there a way to be notified when a setting is changed?
I want GRenderWindow::LockPointer() or GRenderWindow::UnlockPointer() to be called when Ctrl+F9 is pressed (the value of mouse_panning is changed).
I could just add it to the end of the key press listener but I feel there is a better way.

liamwhite commented at 2024-02-25 04:58:

There is no way to be notified, as far as I know - however, given that the Qt main loop is polled at 60 frames per second, you would probably be fine to just recheck the value of the setting next time you need to process an event?

liamwhite commented at 2024-02-26 19:31:

cc @abouvier for cmake review

[Export of Github issue for yuzu-emu/yuzu. Generated on 2024.02.28 at 10:04:32.]

**Branch:** [__refs_pull_13147_head](https://accord.dravee.dev/Accord/yuzu-mirror/src/branch/__refs_pull_13147_head) #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/334272?u=3acce2adcf9f1cf45a3b162d0cab3fdf990fd865&v=4" width="50"></div>[ColinKinloch](https://github.com/ColinKinloch) opened issue at [2024-02-24 01:38](https://github.com/yuzu-emu/yuzu/pull/13147): > This fixes mouse panning on wayland. > It also adds `wp_viewporter` which allows the compositor to scale the framebuffer to the window. This may make resizing the window smoother on slow hardware. > ## To do > - [x] Fix viewport on scaled desktops > - [x] Lock / unlock pointer when mouse panning is disabled / enabled > - [x] Disable wayland incompatible relative mouse panning on wayland #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/334272?u=3acce2adcf9f1cf45a3b162d0cab3fdf990fd865&v=4" width="50"></div>[ColinKinloch](https://github.com/ColinKinloch) commented at [2024-02-24 22:39](https://github.com/yuzu-emu/yuzu/pull/13147#issuecomment-1962748526): > Is there a way to be notified when a setting is changed? > I want `GRenderWindow::LockPointer()` or `GRenderWindow::UnlockPointer()` to be called when Ctrl+F9 is pressed (the value of mouse_panning is changed). > I could just add it to the end of the key press listener but I feel there is a better way. #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/9658600?v=4" width="50"></div>[liamwhite](https://github.com/liamwhite) commented at [2024-02-25 04:58](https://github.com/yuzu-emu/yuzu/pull/13147#issuecomment-1962813315): > There is no way to be notified, as far as I know - however, given that the Qt main loop is polled at 60 frames per second, you would probably be fine to just recheck the value of the setting next time you need to process an event? #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/9658600?v=4" width="50"></div>[liamwhite](https://github.com/liamwhite) commented at [2024-02-26 19:31](https://github.com/yuzu-emu/yuzu/pull/13147#issuecomment-1965083909): > cc @abouvier for cmake review > ------------------------------------------------------------------------------- > [Export of Github issue for [yuzu-emu/yuzu](https://github.com/yuzu-emu/yuzu). Generated on 2024.02.28 at 10:04:32.]
bootmanager: Add wayland protocols
Some checks failed
yuzu-ci / transifex (pull_request) Has been cancelled
yuzu-ci / reuse (pull_request) Has been cancelled
codespell / Check for spelling errors (pull_request) Has been cancelled
yuzu verify / verify format (pull_request) Has been cancelled
yuzu verify / test build (pull_request) Has been cancelled
yuzu verify / test build-1 (pull_request) Has been cancelled
yuzu verify / test build-2 (pull_request) Has been cancelled
yuzu verify / test build (macos) (pull_request) Has been cancelled
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
yuzu verify / android (pull_request) Has been cancelled
395be2269b
* zwp_relative_pointer_v1 + zwp_locked_pointer_v1 for mouse panning
* wp_viewporter for compositor side scaling
Some checks failed
yuzu-ci / transifex (pull_request) Has been cancelled
yuzu-ci / reuse (pull_request) Has been cancelled
codespell / Check for spelling errors (pull_request) Has been cancelled
yuzu verify / verify format (pull_request) Has been cancelled
yuzu verify / test build (pull_request) Has been cancelled
yuzu verify / test build-1 (pull_request) Has been cancelled
yuzu verify / test build-2 (pull_request) Has been cancelled
yuzu verify / test build (macos) (pull_request) Has been cancelled
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
yuzu verify / android (pull_request) Has been cancelled
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin __refs_pull_13147_head:__refs_pull_13147_head
git switch __refs_pull_13147_head

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff __refs_pull_13147_head
git switch __refs_pull_13147_head
git rebase master
git switch master
git merge --ff-only __refs_pull_13147_head
git switch __refs_pull_13147_head
git rebase master
git switch master
git merge --no-ff __refs_pull_13147_head
git switch master
git merge --squash __refs_pull_13147_head
git switch master
git merge --ff-only __refs_pull_13147_head
git switch master
git merge __refs_pull_13147_head
git push origin master
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Accord/yuzu-mirror!13147
No description provided.