Accord/yuzu-mirror
1
0
Fork 0
Code Issues 1.6k Pull requests 44 Projects Releases Packages Wiki Activity Actions

open [13174] glue/time: Remove global variables #13174

Open
Accord wants to merge 2 commits from __refs_pull_13174_head into master
pull from: __refs_pull_13174_head
merge into: Accord:master
Conversation 0 Commits 2 Files changed 15 +167 -171
Accord commented 2026-01-02 20:43:31 -03:00
Owner
Copy link

Branch: __refs_pull_13174_head

Labels: early-access-merge, android-merge

FearlessTobi opened issue at 2024-02-26 23:08:

These have no good reason to be there, so I made them class members instead.
Also ports https://github.com/citra-emu/citra/pull/7463 from Citra.

[Export of Github issue for yuzu-emu/yuzu. Generated on 2024.02.28 at 10:04:32.]

**Branch:** [__refs_pull_13174_head](https://accord.dravee.dev/Accord/yuzu-mirror/src/branch/__refs_pull_13174_head) > **Labels**: `early-access-merge`, `android-merge` #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/20753089?u=4c1e2e5b0b4b5b40b1004b7fe0948d56f0adaf50&v=4" width="50"></div>[FearlessTobi](https://github.com/FearlessTobi) opened issue at [2024-02-26 23:08](https://github.com/yuzu-emu/yuzu/pull/13174): > These have no good reason to be there, so I made them class members instead. > Also ports https://github.com/citra-emu/citra/pull/7463 from Citra. > ------------------------------------------------------------------------------- > [Export of Github issue for [yuzu-emu/yuzu](https://github.com/yuzu-emu/yuzu). Generated on 2024.02.28 at 10:04:32.]
- ensures log strings match the amount and type (if the format specifies an integer, for example) of the arguments
- if at any later point a runtime-generated string is used as the log format, FmtLogMessage might require an overload taking a fmt::runtime_format_string<> as the format argument type, everything else being equal. wrap the generated string with fmt::runtime() before passing to the LOG_X functio
glue/time: Remove global variables
Some checks failed
yuzu-ci / transifex (pull_request) Has been cancelled
Details
yuzu-ci / reuse (pull_request) Has been cancelled
Details
codespell / Check for spelling errors (pull_request) Has been cancelled
Details
yuzu verify / verify format (pull_request) Has been cancelled
Details
yuzu verify / test build (pull_request) Has been cancelled
Details
yuzu verify / test build-1 (pull_request) Has been cancelled
Details
yuzu verify / test build-2 (pull_request) Has been cancelled
Details
yuzu verify / test build (macos) (pull_request) Has been cancelled
Details
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
Details
yuzu verify / android (pull_request) Has been cancelled
Details
7d12848265 
These serve no good purpose and can be turned into class members instead.
Some checks failed
yuzu-ci / transifex (pull_request) Has been cancelled
Details
yuzu-ci / reuse (pull_request) Has been cancelled
Details
codespell / Check for spelling errors (pull_request) Has been cancelled
Details
yuzu verify / verify format (pull_request) Has been cancelled
Details
yuzu verify / test build (pull_request) Has been cancelled
Details
yuzu verify / test build-1 (pull_request) Has been cancelled
Details
yuzu verify / test build-2 (pull_request) Has been cancelled
Details
yuzu verify / test build (macos) (pull_request) Has been cancelled
Details
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
Details
yuzu verify / android (pull_request) Has been cancelled
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin __refs_pull_13174_head:__refs_pull_13174_head
git switch __refs_pull_13174_head

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff __refs_pull_13174_head
git switch __refs_pull_13174_head
git rebase master
git switch master
git merge --ff-only __refs_pull_13174_head
git switch __refs_pull_13174_head
git rebase master
git switch master
git merge --no-ff __refs_pull_13174_head
git switch master
git merge --squash __refs_pull_13174_head
git switch master
git merge --ff-only __refs_pull_13174_head
git switch master
git merge __refs_pull_13174_head
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Accord/yuzu-mirror!13174
No description provided.