Accord/yuzu-mirror
1
0
Fork 0
Code Issues 1.6k Pull requests 44 Projects Releases Packages Wiki Activity Actions

open [13178] renderer_vulkan: fallback to D32 for missing D24X8 #13178

Open
Accord wants to merge 1 commit from __refs_pull_13178_head into master
pull from: __refs_pull_13178_head
merge into: Accord:master
Conversation 0 Commits 1 Files changed 1 +8
Accord commented 2026-01-02 20:43:34 -03:00
Owner
Copy link

Branch: __refs_pull_13178_head

Labels: gpu-fix, mainline-merge, vulkan, amd

liamwhite opened issue at 2024-02-27 02:10:

Literally just for AMD. This was already handled for D24S8 but forgotten for the dontcare version. https://github.com/yuzu-emu/yuzu/pull/13122#issuecomment-1965630414

FireBurn commented at 2024-02-27 08:44:

Thanks, this fixes the sky box issue, the colours are still wrong though, is that due directly to the fall back? I'm seeing it on Radv and Turnip, I can raise it with Mesa if you think the bug lies there

liamwhite commented at 2024-02-27 14:33:

No, it's probably a yuzu bug.

[Export of Github issue for yuzu-emu/yuzu. Generated on 2024.02.28 at 10:04:32.]

**Branch:** [__refs_pull_13178_head](https://accord.dravee.dev/Accord/yuzu-mirror/src/branch/__refs_pull_13178_head) > **Labels**: `gpu-fix`, `mainline-merge`, `vulkan`, `amd` #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/9658600?v=4" width="50"></div>[liamwhite](https://github.com/liamwhite) opened issue at [2024-02-27 02:10](https://github.com/yuzu-emu/yuzu/pull/13178): > Literally just for AMD. This was already handled for D24S8 but forgotten for the dontcare version. https://github.com/yuzu-emu/yuzu/pull/13122#issuecomment-1965630414 #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/86515?u=3d05f704bde6e66b3c9da38d07802e176c4aace1&v=4" width="50"></div>[FireBurn](https://github.com/FireBurn) commented at [2024-02-27 08:44](https://github.com/yuzu-emu/yuzu/pull/13178#issuecomment-1966049050): > Thanks, this fixes the sky box issue, the colours are still wrong though, is that due directly to the fall back? I'm seeing it on Radv and Turnip, I can raise it with Mesa if you think the bug lies there #### <div><img width="50" height="50" src="https://avatars.githubusercontent.com/u/9658600?v=4" width="50"></div>[liamwhite](https://github.com/liamwhite) commented at [2024-02-27 14:33](https://github.com/yuzu-emu/yuzu/pull/13178#issuecomment-1966686327): > No, it's probably a yuzu bug. > ------------------------------------------------------------------------------- > [Export of Github issue for [yuzu-emu/yuzu](https://github.com/yuzu-emu/yuzu). Generated on 2024.02.28 at 10:04:32.]
renderer_vulkan: fallback to D32 for missing D24X8
Some checks failed
yuzu-ci / transifex (pull_request) Has been cancelled
Details
yuzu-ci / reuse (pull_request) Has been cancelled
Details
codespell / Check for spelling errors (pull_request) Has been cancelled
Details
yuzu verify / verify format (pull_request) Has been cancelled
Details
yuzu verify / test build (pull_request) Has been cancelled
Details
yuzu verify / test build-1 (pull_request) Has been cancelled
Details
yuzu verify / test build-2 (pull_request) Has been cancelled
Details
yuzu verify / test build (macos) (pull_request) Has been cancelled
Details
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
Details
yuzu verify / android (pull_request) Has been cancelled
Details
93e22ae607
Some checks failed
yuzu-ci / transifex (pull_request) Has been cancelled
Details
yuzu-ci / reuse (pull_request) Has been cancelled
Details
codespell / Check for spelling errors (pull_request) Has been cancelled
Details
yuzu verify / verify format (pull_request) Has been cancelled
Details
yuzu verify / test build (pull_request) Has been cancelled
Details
yuzu verify / test build-1 (pull_request) Has been cancelled
Details
yuzu verify / test build-2 (pull_request) Has been cancelled
Details
yuzu verify / test build (macos) (pull_request) Has been cancelled
Details
yuzu verify / test build (windows, msvc) (pull_request) Has been cancelled
Details
yuzu verify / android (pull_request) Has been cancelled
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin __refs_pull_13178_head:__refs_pull_13178_head
git switch __refs_pull_13178_head

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff __refs_pull_13178_head
git switch __refs_pull_13178_head
git rebase master
git switch master
git merge --ff-only __refs_pull_13178_head
git switch __refs_pull_13178_head
git rebase master
git switch master
git merge --no-ff __refs_pull_13178_head
git switch master
git merge --squash __refs_pull_13178_head
git switch master
git merge --ff-only __refs_pull_13178_head
git switch master
git merge __refs_pull_13178_head
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Accord/yuzu-mirror!13178
No description provided.